Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent bar chart from expanding #623

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Prevent bar chart from expanding #623

merged 2 commits into from
Sep 2, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented Sep 2, 2022 •
edited
Loading

Related issue(s) and PR(s)

This PR closes #611

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the CSS property display: block ruby was removed because it's not supported in Chrome
  • instead the <p> tags in the label are prevented from line-wrapping

Screenshot of the fix

Testing

  • Check the bar chart in several browsers, especially Chrome

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested a review from a team September 2, 2022 11:21
KattisLej
KattisLej approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, looks good :)

@KattisLej KattisLej merged commit 0994103 into develop Sep 2, 2022
@KattisLej KattisLej deleted the fix/barchart-expanding branch September 2, 2022 13:08
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KattisLej KattisLej KattisLej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statistics bar expands when the text gets too long
2 participants
@HenrikeW @KattisLej